Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mislabeled privacy setting #2044

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Fix mislabeled privacy setting #2044

merged 2 commits into from
Jan 4, 2022

Conversation

Cauchon
Copy link
Contributor

@Cauchon Cauchon commented Jan 2, 2022

**By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Fixed a mislabeled option in settings where it references a non-existent "Top Ads" section. It should instead reference "Top Blocked Domains"

How does this PR accomplish the above?:

Fixed a mislabeled option in settings

What documentation changes (if any) are needed to support this PR?:

None

  • You must follow the template instructions. Failure to do so will result in your issue being closed.
  • Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.
  • Detail helps us understand an issue quicker, but please ensure it's relevant.

settings.php Outdated Show resolved Hide resolved
Co-authored-by: yubiuser <[email protected]>
@yubiuser
Copy link
Member

yubiuser commented Jan 2, 2022

@PromoFaux
Copy link
Member

DCO is complaining:

As it's a grammar/copy change rather than code - I'm happy to set DCO to pass manually

@PromoFaux PromoFaux merged commit dbcafc3 into pi-hole:devel Jan 4, 2022
@PromoFaux PromoFaux mentioned this pull request Jan 4, 2022
@Cauchon Cauchon deleted the devel branch January 4, 2022 21:05
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-13-web-v5-10-and-core-v5-8-released/52254/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants