Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border to status indicators in the LCARS theme #2024

Merged
merged 1 commit into from
Dec 24, 2021

Conversation

Iksas
Copy link
Contributor

@Iksas Iksas commented Dec 24, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

The green status indicators in the LCARS theme are hard to see on the light background. This PR aims to fix that.
Here's a before and after on a high DPI display:

before-highdpi

with-border-hidpi

And on a low DPI display:

before-lowdpi
with-border-lowdpi

Successfully tested in Firefox, Safari and mobile Safari.

How does this PR accomplish the above?:

A small border is added in the CSS.

What documentation changes (if any) are needed to support this PR?:

none

@rdwebdesign
Copy link
Member

I'm already working on a few fixes for the theme.

I think this is fine, but I'd like to try a softer/thinner edge.
Could you try with the color: rgba(0, 0, 0, 0.5)?

Also, since you are add a border, please remove the .user-panel .info span svg (just above your new code).

@Iksas Iksas force-pushed the lcars-circle-border branch from cc459c1 to 167f361 Compare December 24, 2021 17:46
@Iksas
Copy link
Contributor Author

Iksas commented Dec 24, 2021

I have implemented your suggestions and updated the screenshots.

@rdwebdesign
Copy link
Member

I think it's better.

@yubiuser yubiuser merged commit cca2f78 into pi-hole:devel Dec 24, 2021
@PromoFaux PromoFaux mentioned this pull request Jan 4, 2022
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-13-web-v5-10-and-core-v5-8-released/52254/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants