Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Pi-hole docs when showing dnsmasq warnings #2017

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 23, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Point users to our docs when they see dnsmasq warnings in the Pi-hole diagnosis system.

How does this PR accomplish the above?:

See title

Screenshot from 2021-12-23 11-29-43

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER DL6ER force-pushed the tweak/dnsmasq_warn_docs branch from 1f45c44 to 5eb2e23 Compare December 23, 2021 10:36
@DL6ER DL6ER merged commit 2fb57d2 into devel Dec 23, 2021
@DL6ER DL6ER deleted the tweak/dnsmasq_warn_docs branch December 23, 2021 19:22
@PromoFaux PromoFaux mentioned this pull request Jan 4, 2022
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-13-web-v5-10-and-core-v5-8-released/52254/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants