Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce eye size #2015

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Reduce eye size #2015

merged 1 commit into from
Dec 22, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 22, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Reduce eye size to make it less obtrusive. This also removes the extra vertical padding between the legend items.

Comparison:
ezgif-5-b89f5c4a73
(larger icons and more spacing is before, smaller icon and reduced padding is with this PR)

How does this PR accomplish the above?:

Reduce font-size of the eye from 17px to 14px to make the eye smaller

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER DL6ER added the PR: Approval Required Open Pull Request, needs approval label Dec 22, 2021
@yubiuser yubiuser merged commit 42a7bbe into devel Dec 22, 2021
@yubiuser yubiuser deleted the tweak/smaller_eye branch December 22, 2021 08:59
@DL6ER DL6ER mentioned this pull request Dec 22, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants