Improve interface settings #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…simply "Interface settings") to address issue #2009 Signed-off-by: DL6ER <[email protected]>
…ally bind to an interface. Signed-off-by: DL6ER <[email protected]>
This was referenced Dec 19, 2021
|
Screenshot of the updated settings:
|
|
Before we had the warning text only in regard to "all origins". Now we include "respond" (previously "listen") and "bind" into this section. Did our judgement about the danger and firewall necessity change? |
|
Yes, imagine a user configures a Pi-hole running on a cloud server to listen on the outside interface. Without a firewall this immediately becomes an open resolver. |
rdwebdesign
reviewed
Dec 19, 2021
Signed-off-by: DL6ER <[email protected]>
|
Updated screenshot |
yubiuser
approved these changes
Dec 20, 2021
Merged
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1 |
This was referenced Dec 22, 2021
Closed
8 tasks
This was referenced Jan 3, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase)What does this PR aim to accomplish?:
Fix #2009
How does this PR accomplish the above?:
Add new option to really bind to the specified interface and take care that the description does not imply we are doing this with the other options. See the referenced issue ticket for why this is confusing.
Accompanying pull requests:
What documentation changes (if any) are needed to support this PR?:
See pi-hole/docs#620