Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of domains on adlist is total number not valid number #1995

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Dec 2, 2021

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Only change wording. We report for every adlist the number of domains on that list. Previously, this number was name "valid domains", which is incorrect. Actually, we store the number of total domains of that list, not the number of valid domains (which can, obviously, be smaller)

https://github.com/pi-hole/pi-hole/blob/b5e0f142ccefe9b1b59b94d7e82d3052efbfdcd0/gravity.sh#L251

and

https://github.com/pi-hole/pi-hole/blob/b5e0f142ccefe9b1b59b94d7e82d3052efbfdcd0/gravity.sh#L520-L521

@yubiuser yubiuser requested a review from a team December 2, 2021 22:22
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Dec 2, 2021
@DL6ER DL6ER merged commit 91def08 into devel Dec 3, 2021
@DL6ER DL6ER deleted the fix/valid branch December 3, 2021 05:51
@DL6ER DL6ER mentioned this pull request Dec 22, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants