Revert "Remove duplicated code as it is already part of utils.stateLoadCallback" #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adCallback" This reverts commit 395b1b6. Signed-off-by: Christian König <[email protected]>
DL6ER
approved these changes
Nov 16, 2021
Merged
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1 |
This was referenced Dec 22, 2021
Closed
This was referenced Jan 3, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 395b1b6.
git rebase)git commit --signoff)What does this PR aim to accomplish?:
Commit 395b1b6 (part of #1944) removed an important
ifclause that returnednullif the specific data was not found in the LocalStorage of the browser.E.g. this is the case when Pi-hole web GUI is opened the first time.
Without the revert, the tables wont load properly. Reason is that non-existing data can not be modified.
How does this PR accomplish the above?:
Revert the commit.