Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long-term graph changes #1969

Merged
merged 5 commits into from
Nov 12, 2021
Merged

Long-term graph changes #1969

merged 5 commits into from
Nov 12, 2021

Conversation

rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Nov 12, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Fix #1968

How does this PR accomplish the above?:

  • this PR changes the minimum date allowed for the "daterangepicker", ensuring that the beginning of the displayed graph matches the oldest data contained in the database.

  • The maximum date is limited to "today" (the limits apply to all ranges).

  • a call to the API retrieves the oldest date from the database (getMinTimestamp);

  • this value is used to limit the daterangepicker selector.

  • the code that controls the "interval" between ticks was changed too.

What documentation changes (if any) are needed to support this PR?:
none

@yubiuser yubiuser linked an issue Nov 12, 2021 that may be closed by this pull request
Signed-off-by: rdwebdesign <[email protected]>
Signed-off-by: rdwebdesign <[email protected]>
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:
Bildschirmfoto zu 2021-11-12 20-17-44

After:
Bildschirmfoto zu 2021-11-12 20-18-59

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/show-oldest-date-instead-of-dec-31st-1969-for-all-time-in-long-term-data/32807/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long-term graphic for "All Time" need some adjustment
3 participants