Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to message table how to generate debug log #1962

Merged
merged 2 commits into from
Nov 21, 2021
Merged

Add note to message table how to generate debug log #1962

merged 2 commits into from
Nov 21, 2021

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Nov 9, 2021

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Does what it says.

Bildschirmfoto zu 2021-11-09 07-06-54

@DL6ER
Copy link
Member

DL6ER commented Nov 9, 2021

Is this change intended?

Screenshot from 2021-11-09 17-00-35

@yubiuser
Copy link
Member Author

yubiuser commented Nov 9, 2021

No, don't know how it got there. This is for another PR that might come or might not come. Deleted it.

@yubiuser yubiuser requested a review from a team November 20, 2021 12:50
messages.php Outdated Show resolved Hide resolved
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2021-11-21 21-33-05

@DL6ER DL6ER merged commit 30f4b2f into devel Nov 21, 2021
@DL6ER DL6ER deleted the diagnosis branch November 21, 2021 20:33
@DL6ER DL6ER mentioned this pull request Dec 22, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants