Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes background of the dark-midnight theme #1961

Closed
wants to merge 1 commit into from
Closed

Fixes background of the dark-midnight theme #1961

wants to merge 1 commit into from

Conversation

xopez
Copy link
Contributor

@xopez xopez commented Nov 8, 2021

Signed-off-by: xopez [email protected]

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

This PR fixes the background of the dark-midnight theme

How does this PR accomplish the above?:

Changing the background in CSS.

What documentation changes (if any) are needed to support this PR?:

Nothing I think.

This PR is a wished new PR. Discussion is found here: #1885

@xopez
Copy link
Contributor Author

xopez commented Nov 8, 2021

I think I misunderstood the signed off for DCO. And the warnings are still there.

@rdwebdesign
Copy link
Member

rdwebdesign commented Nov 9, 2021

Actually, you have 2 different failed tests:

The first one is DCO.

I think I misunderstood the signed off for DCO. And the warnings are still there.

The name and e-mail should macth your github profile information, but you used the wrong name and the wrong e-mail.
The error is explained here, at the end of the page.

Expected "Sascha Moser [email protected]", but got "xopez [email protected]".

The second failed test is CodeFactor.

I don't know why this is happening now, but didn't happened before with this same file.
Maybe the old version was bigger and the test was skipped... I'm really not sure.

@PromoFaux
Copy link
Member

Sorry, that was my fault with the DCO, I gave you the wrong text - however that's fine - I can set that to pass manually. I'll try to look later as to why CodeFactor is being so picky all of a sudden...

DL6ER added a commit that referenced this pull request Nov 21, 2021
Redo of Fixes background of the dark-midnight theme #1961
@DL6ER
Copy link
Member

DL6ER commented Nov 21, 2021

Added through #1966

@DL6ER DL6ER closed this Nov 21, 2021
@xopez xopez deleted the patch-2 branch November 21, 2021 08:11
@DL6ER DL6ER mentioned this pull request Dec 22, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants