Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing blocked boolean in queries.js #1950

Merged
merged 2 commits into from
Oct 31, 2021
Merged

Conversation

dylansealy
Copy link
Contributor

@dylansealy dylansealy commented Oct 28, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

This PR aims to fix a bug where a blocked domain has a green background in the queries table.

How does this PR accomplish the above?:

By adding a missing blocked = true in the switch statement.

What documentation changes (if any) are needed to support this PR?:

None.

@yubiuser
Copy link
Member

Check failure on line 190 in scripts/pi-hole/js/queries.js
Expected blank line before this statement.

Please re-introduce the blank line

Signed-off-by: Dylan Sealy <[email protected]>
@yubiuser
Copy link
Member

Before
Bildschirmfoto zu 2021-10-31 19-16-16

After
Bildschirmfoto zu 2021-10-31 19-15-38

@yubiuser yubiuser merged commit 24b1449 into pi-hole:devel Oct 31, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/cname-block-row-not-highlighted-in-red/50799/4

@DL6ER DL6ER added the Bugfix label Nov 1, 2021
@DL6ER DL6ER mentioned this pull request Dec 22, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants