-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Star Trek LCARS theme #1936
Conversation
Pi-hole web v5.7
Pi-hole Web 5.8
Signed-off-by: rdwebdesign <[email protected]>
Signed-off-by: rdwebdesign <[email protected]>
Thanks. I noticed a few inconsistencies (but that is only minor stuff): The Pi-hole diagnosis system icon is covered by the number (if present). Not sure if this is intended, just mentioning this here. Inner button text arrangement looks off in some smaller buttons. The disabled button has a visible knob in disabled state. The information stored in the color gradient is somewhat lost on the network page when the gradient is not really visible. Else than that this really looks great. |
- toggle button (disabled): knob removed; - gradiend changed; Signed-off-by: rdwebdesign <[email protected]>
As for the buttons: text alignment at the bottom right was intentional (just like the sidebar alignment). If this is too bad or not in accordance with the rules, let me know and I'll place the text back to the original alignment. |
@yubiuser, What do you think about it? Any suggestions? |
I think it is an impressive theme and does fit into Pi-hole's overall Star Trek theme very well. Personally, its't nothing I would use for every-day, especially the font's I don't like very much. But this is my personal taste and should not prevent this PR from being part of Pi-hole. I'm sure a lot of people will like and use it. |
Thank you for your comments. I used these fonts to get the condensed look used in Star Trek panels. This can be modified as needed. I like to hear more opinions, but personal taste is important. I know it's not everyone's choice, but this theme was created for those who are fans and like dark themes. I think it works best on desktops, but it's also been tested on phones and tablets. Do you see any issues if I mark this as ready for review? |
No.
If you like it and it looks like you imagined it to be, that's fine. Design choices do and never will please everyone. |
I agree. |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1 |
Signed-off-by: rdwebdesign [email protected]
By submitting this pull request, I confirm the following:
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
Adds a new pi-hole theme based on the Star Trek LCARS visual (as a tribute and using the "fun" suggestion in the Contributors Guide)
How does this PR accomplish the above?:
The new visual was achieved by adding a new CSS theme only.
What documentation changes (if any) are needed to support this PR?:
None, for now.