Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Star Trek LCARS theme #1936

Merged
merged 7 commits into from
Nov 1, 2021
Merged

Add Star Trek LCARS theme #1936

merged 7 commits into from
Nov 1, 2021

Conversation

rdwebdesign
Copy link
Member

Signed-off-by: rdwebdesign [email protected]

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Adds a new pi-hole theme based on the Star Trek LCARS visual (as a tribute and using the "fun" suggestion in the Contributors Guide)

How does this PR accomplish the above?:

The new visual was achieved by adding a new CSS theme only.

  • This new theme DOES NOT change files from the "vendor" directory.
  • This new theme DOES NOT change files from other themes.
  • This new theme only includes new CSS files (and Fonts).

What documentation changes (if any) are needed to support this PR?:

None, for now.

@yubiuser
Copy link
Member

Wow, that's impressive!

Bildschirmfoto zu 2021-10-24 12-50-27
Bildschirmfoto zu 2021-10-24 12-50-43
Bildschirmfoto zu 2021-10-24 12-50-50
Bildschirmfoto zu 2021-10-24 12-51-01

@DL6ER
Copy link
Member

DL6ER commented Oct 24, 2021

Thanks. I noticed a few inconsistencies (but that is only minor stuff):

Screenshot from 2021-10-24 15-46-26

The Pi-hole diagnosis system icon is covered by the number (if present). Not sure if this is intended, just mentioning this here.


Screenshot from 2021-10-24 15-46-32

Screenshot from 2021-10-24 15-47-01

Screenshot from 2021-10-24 15-53-01

Screenshot from 2021-10-24 15-53-08

Inner button text arrangement looks off in some smaller buttons.


Screenshot from 2021-10-24 15-46-53

The disabled button has a visible knob in disabled state.


Screenshot from 2021-10-24 15-48-31

The information stored in the color gradient is somewhat lost on the network page when the gradient is not really visible.


Else than that this really looks great.

@rdwebdesign
Copy link
Member Author

@DL6ER,

  • I fixed the ugly disabled toggle button (I really missed that one).
  • I also changed the gradient of the network table to different colors. I tried to keep dark tones, but with visible contrast. See if it's better.
  • The Pi-hole diagnosis system icon was cover as a side effect of other changes. It's fixed now.

As for the buttons: text alignment at the bottom right was intentional (just like the sidebar alignment). If this is too bad or not in accordance with the rules, let me know and I'll place the text back to the original alignment.

@rdwebdesign rdwebdesign marked this pull request as draft October 29, 2021 04:13
@rdwebdesign
Copy link
Member Author

@yubiuser,
I saw you tried this PR.

What do you think about it? Any suggestions?

@yubiuser
Copy link
Member

I think it is an impressive theme and does fit into Pi-hole's overall Star Trek theme very well. Personally, its't nothing I would use for every-day, especially the font's I don't like very much. But this is my personal taste and should not prevent this PR from being part of Pi-hole. I'm sure a lot of people will like and use it.
I just played with it the last 10 minutes and did not see any visual bugs. Give us a note if you think the PR is ready for review.

@rdwebdesign
Copy link
Member Author

rdwebdesign commented Oct 31, 2021

@yubiuser

Thank you for your comments.

I used these fonts to get the condensed look used in Star Trek panels. This can be modified as needed.

I like to hear more opinions, but personal taste is important.
I generally don't use dark themes. Usually I use the clear theme.

I know it's not everyone's choice, but this theme was created for those who are fans and like dark themes. I think it works best on desktops, but it's also been tested on phones and tablets.

Do you see any issues if I mark this as ready for review?

@yubiuser
Copy link
Member

Do you see any issues if I mark this as ready for review?

No.

I know it's not everyone's choice, but this theme was created for those who are fans and like dark themes.
This can be modified as needed.

If you like it and it looks like you imagined it to be, that's fine. Design choices do and never will please everyone.

@rdwebdesign rdwebdesign marked this pull request as ready for review October 31, 2021 22:00
@rdwebdesign
Copy link
Member Author

I agree.
Design choices are personal..., but I accept ideas.

@yubiuser yubiuser changed the title Testing new theme Add Star Trek LCARS theme Nov 1, 2021
@yubiuser yubiuser merged commit ca97e13 into pi-hole:devel Nov 1, 2021
@DL6ER DL6ER mentioned this pull request Dec 22, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants