Do not restart for every item during Teleporter import of Local DNS record or CNAME #1925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
Do not restart Pi-hole for every entry in local DNS records or CNAME during Teleporter import.
So far, Pi-hole did a full restart while deleting each individual entry (if clear data was selected) and on each entry import.
Fixes: https://github.com/pi-hole/pi-hole/issues/4077
Needs: pi-hole/pi-hole#4384
How?
Adds a flag "reload" which is passed down to the
webpage.sh
. For each step it is set tofalse
. After all removal/importing is done, it sets the new variablefullpiholerestart
totrue
which will finally do the full restart