Make entire Forgot Password box header clickable #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjusts the markup for the Forgot Password box such that the entire box header (the text, whitespace and plus/minus icon) is interactive. Previous behaviour of clicking the icon remains the same. This also improves the markup/spacing inside the box's content. Signed-off-by: David Beitey <[email protected]>
yubiuser
approved these changes
Oct 5, 2021
yubiuser
added
the
PR: Approved
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-11-web-v5-8-and-core-v5-6-released/50566/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase)git commit --signoff)What does this PR aim to accomplish?:
To improve the usability & readability of the login screen's Forgot Password box.
Currently, a user must specifically click on the
+(plus) icon to reveal the hidden instructions, which can be confusing as it is common that a collapsed box's header and header text is interactive (for example, Bootstrap's Accordion component).How does this PR accomplish the above?:
This adjusts the markup for the Forgot Password box to make the entire box header interactive (the text, whitespace and plus/minus icon). The previous behaviour of clicking the icon remains the same as does the icon changing between plus and minus depending on the collapsed status.
This also improves the readability of the forgotten password box's content with a small change in markup.
What documentation changes (if any) are needed to support this PR?:
None that I'm aware of.