fix: exclude status checkboxes from being treated as iCheck elements

[lionralfs]

By submitting this pull request, I confirm the following:

• I have read and understood the contributors guide, as well as this entire template.
• I have made only one major change in my proposed changes.
• I have commented my proposed changes within the code.
• I have tested my proposed changes.
• I am willing to help maintain this change if there are issues with it later.
• I give this submission freely and claim no ownership.
• It is compatible with the EUPL 1.2 license
• I have squashed any insignificant commits. (git rebase)
• I have Signed Off all commits. (git commit --signoff)

---

What does this PR aim to accomplish?:

Fixes #1849.
In Safari, the toggle buttons under Group Management > Groups are broken.
This is due to the following phenomenon: The data table is rendered before these lines in footer.js:
https://github.com/pi-hole/AdminLTE/blob/50f43bde73d25211ac2c81e9092be67512611d2a/scripts/pi-hole/js/footer.js#L140-L143

This obviously leads to all classes being removed, along with their styling.
The more interesting question is: why does every other browser render the data table after these lines in footer.js? I honestly don't have a good answer.

Other pages don't cause this issue in Safari due to how the data fetching is implemented (an explicit initTable callback function which gets pushed onto the call stack). I considered using the same implementation here, but
in my opinion this wouldn't avoid the issue from occurring, because it is still somewhat of a race condition.

How does this PR accomplish the above?:

To avoid race conditions in general, I added an exception to the initialization of iCheck elements by using a :not selector for all elements that have an id attribute starting with "status_".

What documentation changes (if any) are needed to support this PR?:

none

[PromoFaux]

@jfb-pihole, as you were able to reproduce the issue that this PR fixes - can you please check that this fixes it? Thanks!

[PromoFaux]

Just to note, you wont be able to use pihole checkout web [branch] but you should be able to:

cd /var/www/html/admin
git checkout -b lionralfs-fix/1849-checkboxes devel
git pull https://github.com/lionralfs/AdminLTE.git fix/1849-checkboxes

[sbytnar]

Hi. For this same bug, I use
.not('["data-toggle"="toggle"]'); // Skip bootstrapToggle which has its own theme.
instead of
.not("[id^=status_]")

Approvers... please do consider merging this PR as-is though. EIther way, this modification fixes the #1849 problem.

[yubiuser]

I checked, `id="status_" does only occur three times, all on the group management pages.

[yubiuser]

I had a similar issue on iPadOS 15.1 both on Safari and Chrome. The would not display the relevant tables to all. This PR fixed the issue.

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/list-of-configured-groups-only-shows-a-green-square/51178/2

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1