Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not default true for unset variables DNS_FQDN_REQUIRED and DNS_BOGUS_PRIV #1909

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Do not default true for unset variables DNS_FQDN_REQUIRED and DNS_BOGUS_PRIV #1909

merged 1 commit into from
Oct 4, 2021

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Oct 2, 2021

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Do not default true for unset variables. When DNS_FQDN_REQUIRED and DNS_BOGUS_PRIV have not been set in setupVars.conf at all, the relevant checkboxes in the web GUI were checked anyway. We don't do that for other variables (e.g. DNSSEC) and I think we shouldn't do this. If something is not set at all, we can not pretend it would be true.

How does this PR accomplish the above?:

Change the default to false

What documentation changes (if any) are needed to support this PR?:
None.

@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Oct 2, 2021
@PromoFaux PromoFaux merged commit eb44144 into pi-hole:devel Oct 4, 2021
@yubiuser yubiuser deleted the change_default branch October 4, 2021 20:53
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-11-web-v5-8-and-core-v5-6-released/50566/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants