Do not default true for unset variables DNS_FQDN_REQUIRED
and DNS_BOGUS_PRIV
#1909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
Do not default true for unset variables. When
DNS_FQDN_REQUIRED
andDNS_BOGUS_PRIV
have not been set insetupVars.conf
at all, the relevant checkboxes in the web GUI were checked anyway. We don't do that for other variables (e.g.DNSSEC
) and I think we shouldn't do this. If something is not set at all, we can not pretend it would be true.How does this PR accomplish the above?:
Change the default to
false
What documentation changes (if any) are needed to support this PR?:
None.