Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1777 "Remember me for 7 days" doesn't work if you log in from Recent Queries #1870

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

chrismiceli
Copy link
Contributor

@chrismiceli chrismiceli commented Aug 30, 2021

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • [ x ] I have read and understood the contributors guide, as well as this entire template.
  • [ x ] I have made only one major change in my proposed changes.
  • [ x ] I have commented my proposed changes within the code.
  • [ x ] I have tested my proposed changes.
  • [ x ] I am willing to help maintain this change if there are issues with it later.
  • [ x ] I give this submission freely and claim no ownership.
  • [ x ] It is compatible with the EUPL 1.2 license
  • [ x ] I have squashed any insignificant commits. (git rebase)
  • [ x ] I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Attempts to resolve https://github.com/pi-hole/AdminLTE/issues/1777

How does this PR accomplish the above?:

By setting the cookie in the case of logging in from a deep link

What documentation changes (if any) are needed to support this PR?:

None as this should be the expected behavior.

@chrismiceli chrismiceli changed the base branch from master to devel August 30, 2021 01:38
@chrismiceli chrismiceli changed the title Issue/1777 #1777 "Remember me for 7 days" doesn't work if you log in from Recent Queries Aug 31, 2021
…eries

set cookie if requested

Signed-off-by: Chris Miceli <[email protected]>
@chrismiceli
Copy link
Contributor Author

Is there anything else I need to do to facilitate getting this merged?

@DL6ER
Copy link
Member

DL6ER commented Sep 26, 2021

No, sorry for the delay on reviewing this. As you know, Pi-hole is only a volunteer project and sometimes (yes, I know, I should say "often"), we come here to fix some things on our own but don't get around reviewing external contributions. You have my apologies and I'll merge your PR given that all automated tests pass.

@chrismiceli
Copy link
Contributor Author

No, sorry for the delay on reviewing this. As you know, Pi-hole is only a volunteer project and sometimes (yes, I know, I should say "often"), we come here to fix some things on our own but don't get around reviewing external contributions. You have my apologies and I'll merge your PR given that all automated tests pass.

No worries. I was just making sure I was following the process appropriately and no one was waiting on me.

@yubiuser yubiuser requested a review from DL6ER October 4, 2021 21:22
@PromoFaux PromoFaux merged commit 1ed98f6 into pi-hole:devel Oct 6, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-11-web-v5-8-and-core-v5-6-released/50566/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants