Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reply type DNSSEC #1837

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Add reply type DNSSEC #1837

merged 1 commit into from
Jun 23, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jun 22, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Add new reply type DNSSEC added in pi-hole/FTL#1143

How does this PR accomplish the above?:

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER DL6ER changed the base branch from master to devel June 22, 2021 07:58
@DL6ER DL6ER marked this pull request as ready for review June 23, 2021 08:28
@DL6ER DL6ER requested review from dschaper and PromoFaux June 23, 2021 08:28
@DL6ER
Copy link
Member Author

DL6ER commented Jun 23, 2021

This PR can be merged at any time, also before merging the PR actually implementing this reply type (pi-hole/FTL#1143).

@DL6ER DL6ER marked this pull request as draft June 23, 2021 09:41
@DL6ER DL6ER force-pushed the update/dnsmasq-v2.86 branch from f77e655 to fb2b87e Compare June 23, 2021 09:44
@DL6ER DL6ER marked this pull request as ready for review June 23, 2021 09:44
@DL6ER DL6ER requested a review from PromoFaux June 23, 2021 09:44
@DL6ER DL6ER merged commit 2c97652 into devel Jun 23, 2021
@DL6ER DL6ER deleted the update/dnsmasq-v2.86 branch June 23, 2021 09:58
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-9-web-v5-6-and-core-v5-4-released/49544/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants