Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to obtain hostname for MAC clients #1793

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Try to obtain hostname for MAC clients #1793

merged 1 commit into from
Apr 30, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Apr 29, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Show hostnames also for clients specified by MAC address

How does this PR accomplish the above?:

If we didn't find a hostname for a client's IP address, try to look up the client as MAC address against the network table.

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER
Check if we can get a host name from the database when looking up the…
ca71bc8 
… MAC address of this client instead

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER added Bugfix PR: Approval Required Open Pull Request, needs approval labels Apr 29, 2021
@DL6ER DL6ER requested a review from a team April 29, 2021 07:47
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/client-group-management-issue/46202/24

@DL6ER DL6ER changed the title Check if we can get a host name from the database when looking up the… Try to obtain hostname for MAC clients Apr 29, 2021
@DL6ER DL6ER merged commit eab215e into devel Apr 30, 2021
@DL6ER DL6ER deleted the tweak/group_clients_MAC_hostnames branch April 30, 2021 11:15
@DL6ER DL6ER added PR: Approved Open Pull Request, Approved by required number of reviewers and removed PR: Approval Required Open Pull Request, needs approval labels Apr 30, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-9-web-v5-6-and-core-v5-4-released/49544/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschaper dschaper dschaper approved these changes

Assignees
No one assigned
Labels
Bugfix PR: Approved Open Pull Request, Approved by required number of reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DL6ER @pralor-bot @dschaper