Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pi-hole darker theme #1731

Merged
merged 2 commits into from
Feb 28, 2021
Merged

Add Pi-hole darker theme #1731

merged 2 commits into from
Feb 28, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 5, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

This PR adds a third default theme, an even darker variant of the dark one. It also fixes an issues with the existing dark theme where links in box headers (like the Query Log's "show all") were completely invisible:

old:
Screenshot at 2021-02-05 07-38-51

fixed:
Screenshot at 2021-02-05 07-38-33

How does this PR accomplish the above?:

Add a new theme. Comparison between the existing dark (on the left) and the new darker (on the right):

Screenshot_2021-02-05 Pi-hole - ubuntu-server
Screenshot_2021-02-05 Pi-hole - ubuntu-server(1)
Screenshot_2021-02-05 Pi-hole - ubuntu-server(2)

What documentation changes (if any) are needed to support this PR?:

None, this new theme is an opt-in feature.

@DL6ER DL6ER requested a review from a team February 5, 2021 07:11
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/new-unknown-0-status-showing-up/43694/28

Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darker is always better in my eyes :)

@DL6ER DL6ER merged commit 1195920 into devel Feb 28, 2021
@DL6ER DL6ER deleted the fix/dark_theme_links branch February 28, 2021 16:00
@metool6
Copy link

metool6 commented Feb 28, 2021

How do I add this to my pi?

@DL6ER
Copy link
Member Author

DL6ER commented Feb 28, 2021

The next update of Pi-hole will include it.

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-8-web-v5-5-and-core-v5-3-released/46237/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants