Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change radius to 10px for a more modern look. #1691

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

Gontier-Julien
Copy link
Contributor

Signed-off-by: Gontier Julien [email protected]

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

It make the interface look a bit more modern not much but improve the overall visual experience.

How does this PR accomplish the above?:

-Change .small-box and .box from border-radius:3px to border-radius:10px.

What documentation changes (if any) are needed to support this PR?:

None

DL6ER
DL6ER previously requested changes Jan 13, 2021
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be realized without changes in vendor directories (like style/vendor)?

The reason I'm asking is basically two-fold:

  • Due to the licenses of the contained third-party software, changes often have to be submitted upstream
  • Ont he next update of the component, we will have forgotten about this change and simply replace this file with its updated version - undoing your changes unintentionally.

Overwrites are added in style/pi-hole.css, typically where they are guaranteed to stay in our open license and won't be overwritten on component upgrades.

This may also apply to your other PRs, I haven't had the time to look at them so far.

@Gontier-Julien
Copy link
Contributor Author

How right sorry about that i while fix this today, i didn't pay attention to this ^^'
Do you want me to make a new pull request to this ?

@Gontier-Julien
Copy link
Contributor Author

Wrong button*

@DL6ER
Copy link
Member

DL6ER commented Jan 13, 2021

No worries, you can either reuse this PR by undoing your first commit and making a new one + force-push. Or just add the change in a second commit which we can then squash-merge. The latter is probably the easiest.

@Gontier-Julien
Copy link
Contributor Author

Okay no problems i will reuse this PR request and remove this commit and make a new one.

@Gontier-Julien
Copy link
Contributor Author

Sorry about this inconvenience ^^' but now it fixed ^^

Signed-off-by: Adam Warner <[email protected]>
@PromoFaux PromoFaux merged commit 1d52bc8 into pi-hole:devel Jan 13, 2021
This was referenced Jan 15, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-v5-2-3-web-v5-3-and-ftl-v5-4-released/43009/1

@dschaper
Copy link
Member

@Gontier-Julien What is your background for front end? Are you familiar with any frameworks?

@Gontier-Julien
Copy link
Contributor Author

Gontier-Julien commented Feb 3, 2021

@dschaper i currently don't "have" a background in this, but i've had worked for two small enterprise where i've done there interface and helped the dev team. I'm still a student at the moment.
And no i don't have any experience in frameworks, but i can still learn.

@dschaper
Copy link
Member

dschaper commented Feb 3, 2021

I'm very happy to have you contribute and learn as you go, so please don't let that be a barrier to your continuing to contribute. We don't ask for resumes or CVs to contribute, your work speaks for you in that regard.

Front-end design is very much a personal preference for a lot of things but we do come to a consensus almost all of the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants