-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change radius to 10px for a more modern look. #1691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be realized without changes in vendor
directories (like style/vendor
)?
The reason I'm asking is basically two-fold:
- Due to the licenses of the contained third-party software, changes often have to be submitted upstream
- Ont he next update of the component, we will have forgotten about this change and simply replace this file with its updated version - undoing your changes unintentionally.
Overwrites are added in style/pi-hole.css
, typically where they are guaranteed to stay in our open license and won't be overwritten on component upgrades.
This may also apply to your other PRs, I haven't had the time to look at them so far.
How right sorry about that i while fix this today, i didn't pay attention to this ^^' |
Wrong button* |
No worries, you can either reuse this PR by undoing your first commit and making a new one + force-push. Or just add the change in a second commit which we can then squash-merge. The latter is probably the easiest. |
Okay no problems i will reuse this PR request and remove this commit and make a new one. |
Signed-off-by: Gontier Julien <[email protected]>
Sorry about this inconvenience ^^' but now it fixed ^^ |
Signed-off-by: Adam Warner <[email protected]>
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-core-v5-2-3-web-v5-3-and-ftl-v5-4-released/43009/1 |
@Gontier-Julien What is your background for front end? Are you familiar with any frameworks? |
@dschaper i currently don't "have" a background in this, but i've had worked for two small enterprise where i've done there interface and helped the dev team. I'm still a student at the moment. |
I'm very happy to have you contribute and learn as you go, so please don't let that be a barrier to your continuing to contribute. We don't ask for resumes or CVs to contribute, your work speaks for you in that regard. Front-end design is very much a personal preference for a lot of things but we do come to a consensus almost all of the time. |
Signed-off-by: Gontier Julien [email protected]
By submitting this pull request, I confirm the following:
{please fill any appropriate checkboxes, e.g: [X]}
{Please ensure that your pull request is for the 'devel' branch!}
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
It make the interface look a bit more modern not much but improve the overall visual experience.
How does this PR accomplish the above?:
-Change
.small-box
and.box
fromborder-radius:3px
toborder-radius:10px
.What documentation changes (if any) are needed to support this PR?:
None