Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more query type names to title of Query Log instead of "type <id>" #1671

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Add more query type names to title of Query Log instead of "type <id>" #1671

merged 1 commit into from
Dec 28, 2020

Conversation

Daxtorim
Copy link
Contributor

Signed-off-by: Fabian Preuß [email protected]

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

This PR allows translation of all query type ids to their respective names in the title of the query log.
grafik
grafik

How does this PR accomplish the above?:

Added the rest of the known query types from FTL/src/enums.h to the $qtypes array.

What documentation changes (if any) are needed to support this PR?:

None.

Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Too many places where these changes need to propagate through always leave at least one updated... We're working on improving this.

@DL6ER DL6ER merged commit cef3a25 into pi-hole:devel Dec 28, 2020
This was referenced Jan 15, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-v5-2-3-web-v5-3-and-ftl-v5-4-released/43009/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants