Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with Apostrophe turning into ' #1599

Closed
wants to merge 1 commit into from

Conversation

siddhartpai
Copy link

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Fixes issue with Apostrophe ' turning into '

#1584

How does this PR accomplish the above?:

Stops escaping HTML in the comment box in group-adlists page.

@PromoFaux
Copy link
Member

The solution to this may need to be a little smarter than just using whatever is in the text box....

The HTML escaping was added in response to a CVE, so as to prevent XSS attacks.

#1443

@PromoFaux
Copy link
Member

Closing in favour of #1603

@PromoFaux PromoFaux closed this Nov 8, 2020
@siddhartpai siddhartpai deleted the fix/1584 branch November 17, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants