Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color of blocked queries in dashboard piechart forward destination to red #1594

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Change color of blocked queries in dashboard piechart forward destination to red #1594

merged 1 commit into from
Dec 10, 2020

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Sep 30, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Change color of blocked queries in dashboard piechart forward destination to red.

Before
Bildschirmfoto zu 2020-09-30 20-17-52

After
Bildschirmfoto zu 2020-09-30 20-17-45

How does this PR accomplish the above?:

Change to order of colors in THEME_COLORS in index.js.

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/feature-request-queries-answered-by-colours/38870/2

@PromoFaux
Copy link
Member

Are we sure that blocklist will always be the first in the legend? I can't think of anything that would come before it... but obviously if it did then blocklist would again be blue :) Just throwing spanners here...

@yubiuser
Copy link
Member Author

yubiuser commented Nov 8, 2020

As long the forwarddestid of blocklist is not changed it should be the first data send via the api

https://github.com/pi-hole/FTL/blob/dbd4a696afd35efa5e6c4882c74d9102d9d7d6a2/src/api/api.c#L685

@DL6ER DL6ER merged commit 835f12d into pi-hole:devel Dec 10, 2020
@yubiuser yubiuser deleted the tweak/colors branch December 10, 2020 21:11
@PromoFaux PromoFaux mentioned this pull request Dec 23, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-2-and-ftl-v5-3-3-released/41998/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants