Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login page tweak #1583

Merged
merged 2 commits into from
Sep 12, 2020
Merged

Login page tweak #1583

merged 2 commits into from
Sep 12, 2020

Conversation

PromoFaux
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:
Simple tweak to make thigns less confusing for some.

Before PR:

image

After PR:
image

fixes #1572

… obvious which is the correct button.

Signed-off-by: Adam Warner <[email protected]>
@PromoFaux PromoFaux requested a review from DL6ER September 11, 2020 16:48
@PromoFaux
Copy link
Member Author

Oops, forgot to add mobile screenshots.

Before:
image

After:
image

scripts/pi-hole/php/loginpage.php Outdated Show resolved Hide resolved
scripts/pi-hole/php/loginpage.php Show resolved Hide resolved
@PromoFaux PromoFaux merged commit 132a9b9 into devel Sep 12, 2020
@PromoFaux PromoFaux deleted the tweak/login branch September 12, 2020 14:50
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/suggestion-login-forgot-password-buttons/40447/2

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/higher-usability-change-the-size-of-the-buttons-for-login-forgot-pw/3750/9

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants