Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make login form button more mobile friendly #1564

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Make login form button more mobile friendly #1564

merged 1 commit into from
Aug 19, 2020

Conversation

Ninjaclasher
Copy link
Contributor

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Currently, the login actions, "Log in" and "Remember me for 7 days" are squished to the right for a small width screen. Example:

image

This PR moves the "Remember me for 7 days" to the left of the "Log in" button and attaches it to the left of the container.

How does this PR accomplish the above?:

The pull-right is changed to a pull-left. This only affects screens where the keyboard shortcuts are hidden.

After changes on a small width screen:
image

After changes on a very small width screen:
image

After changes on a normal screen: (identical to what it looked like before)
image

What documentation changes (if any) are needed to support this PR?:

No documentation changes should be required. I couldn't find any screenshots of the login page on a small width screen, so I don't think any screenshots need updating.

Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DL6ER DL6ER merged commit 75b051f into pi-hole:devel Aug 19, 2020
@Ninjaclasher Ninjaclasher deleted the ninjaclasher/patch-1 branch August 20, 2020 14:49
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants