Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember last used sort column/direction on Local DNS Records table and CNAME table #1563

Merged
merged 1 commit into from
Nov 8, 2020
Merged

Remember last used sort column/direction on Local DNS Records table and CNAME table #1563

merged 1 commit into from
Nov 8, 2020

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Aug 16, 2020

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Remember the last used sort column/direction for the Local DNS Records table and CNAME table.
Fixes #1486

How does this PR accomplish the above?:

Re-uses code from #1332

What documentation changes (if any) are needed to support this PR?:

Nothing

@yubiuser yubiuser requested a review from PromoFaux September 30, 2020 19:02
@PromoFaux PromoFaux merged commit 0e43b1f into pi-hole:devel Nov 8, 2020
@yubiuser yubiuser deleted the tweak/DNSRecordsCNAMETable branch November 8, 2020 14:49
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/setting-to-set-higher-entrys-in-dns-pulldown-menu/46161/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants