Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IPv6 loopback address to be added #1548

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Aug 4, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Allow IPv6 loopback address to be added

How does this PR accomplish the above?:

Do not require first element of the IP address to be a hex value at any costs. It may also be a : in the valid address ::1

What documentation changes (if any) are needed to support this PR?:

None

…lso be a : in the valid address ::1

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER added the Bugfix label Aug 4, 2020
@DL6ER DL6ER requested a review from PromoFaux August 4, 2020 20:12
@DL6ER DL6ER merged commit 0475225 into release/v5.1.1 Aug 4, 2020
@DL6ER DL6ER deleted the fix/ipv6_localhost_validator branch August 4, 2020 20:17
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-2-released/36964/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants