Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix teleporter bug on hosts with . in their names #1517

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 20, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Fix #1497 #1503 and maybe more

How does this PR accomplish the above?:

Replace "." by "_" in hostnames to work around a PHP Phar bug introduced in #1497

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER DL6ER merged commit b8b8e33 into release/v5.1.1 Jul 21, 2020
@DL6ER DL6ER deleted the fix/teleporter_hostnames branch July 21, 2020 10:52
@PromoFaux PromoFaux mentioned this pull request Jul 24, 2020
@DL6ER DL6ER mentioned this pull request Jul 30, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-2-released/36964/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants