-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tailog pages IDs #1429
Fix tailog pages IDs #1429
Conversation
Signed-off-by: XhmikosR <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<input type="checkbox" checked id="chk1"> | ||
<label for="chk1">Automatic scrolling on update</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<input type="checkbox" checked id="chk1"> | |
<label for="chk1">Automatic scrolling on update</label> | |
<div> | |
<input type="checkbox" checked id="chk1"> | |
<label for="chk1">Automatic scrolling on update</label> | |
</div> |
<input type="checkbox" checked id="chk2"> | ||
<label for="chk2">Automatic scrolling on update</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<input type="checkbox" checked id="chk2"> | |
<label for="chk2">Automatic scrolling on update</label> | |
<div> | |
<input type="checkbox" checked id="chk2"> | |
<label for="chk2">Automatic scrolling on update</label> | |
</div> |
<input type="checkbox" checked id="chk1"> | ||
<label for="chk1">Automatic scrolling on update</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<input type="checkbox" checked id="chk1"> | |
<label for="chk1">Automatic scrolling on update</label> | |
<div> | |
<input type="checkbox" checked id="chk1"> | |
<label for="chk1">Automatic scrolling on update</label> | |
</div> |
<input type="checkbox" checked id="chk2"> | ||
<label for="chk2">Automatic scrolling on update</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<input type="checkbox" checked id="chk2"> | |
<label for="chk2">Automatic scrolling on update</label> | |
<div> | |
<input type="checkbox" checked id="chk2"> | |
<label for="chk2">Automatic scrolling on update</label> | |
</div> |
As you can see the empty divs are not present in devel |
You are welcome to fix those separately. |
Also, these pages do not follow the basic AdminLTE markup, it's not a checkbox issue. They are missing more needed classes, but I don't want to fix them in devel since I fixed those in the AdminLTE 3 branch. |
The check boxes are broken now. I agree. Fixing them along in this PR will not hurt and I don't see a justification for leaving them broken when changing them. |
I want to keep my PRs clean. This does one thing. You are welcome to fix the other issues on a separate PR. |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1 |
Signed-off-by: XhmikosR [email protected]
By submitting this pull request, I confirm the following:
{please fill any appropriate checkboxes, e.g: [X]}
{Please ensure that your pull request is for the 'devel' branch!}
git rebase
)git commit --signoff
)Fixes #1412