-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chartjs to v2.9.3 #1424
Update chartjs to v2.9.3 #1424
Conversation
Signed-off-by: XhmikosR <[email protected]>
Signed-off-by: XhmikosR <[email protected]>
Signed-off-by: XhmikosR <[email protected]>
Signed-off-by: DL6ER <[email protected]>
@DL6ER Are you OK with the changes in the axes? It seems to show more values now. |
This seems to be the standard behavior for the updated Chart.js. We do not mess with axis ticks anywhere. |
Ok, so we are merging? |
Yes, I am waiting for the last test to pass. Feel free to overwrite it if it gets stale, however. |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1 |
By submitting this pull request, I confirm the following:
{please fill any appropriate checkboxes, e.g: [X]}
{Please ensure that your pull request is for the 'devel' branch!}
git rebase
)git commit --signoff
)Fixes #1345.