Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chartjs to v2.9.3 #1424

Merged
merged 4 commits into from
Jun 4, 2020
Merged

Update chartjs to v2.9.3 #1424

merged 4 commits into from
Jun 4, 2020

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jun 3, 2020

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

Fixes #1345.

@XhmikosR XhmikosR added dependencies Pull requests that update a dependency file Requires Testing labels Jun 3, 2020
@XhmikosR XhmikosR requested a review from DL6ER June 3, 2020 14:58
@XhmikosR XhmikosR marked this pull request as ready for review June 4, 2020 11:13
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jun 4, 2020

@DL6ER Are you OK with the changes in the axes? It seems to show more values now.

@DL6ER
Copy link
Member

DL6ER commented Jun 4, 2020

Yes, that's fine. I checked it does automatically adapt when there are too many labels
Screenshot from 2020-06-04 13-37-43

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jun 4, 2020

OK, if you like it. Because this is what I get on my WSL instance which doesn't have a lot of requests

image

@DL6ER
Copy link
Member

DL6ER commented Jun 4, 2020

This seems to be the standard behavior for the updated Chart.js. We do not mess with axis ticks anywhere.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jun 4, 2020

Ok, so we are merging?

@XhmikosR XhmikosR added this to the v5.1 milestone Jun 4, 2020
@DL6ER
Copy link
Member

DL6ER commented Jun 4, 2020

Yes, I am waiting for the last test to pass. Feel free to overwrite it if it gets stale, however.

@XhmikosR XhmikosR merged commit b3e3a3c into devel Jun 4, 2020
@XhmikosR XhmikosR deleted the update-chartjs branch June 4, 2020 11:49
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Requires Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants