Improve messages on the domain management pages

[DL6ER]

By submitting this pull request, I confirm the following:

• I have read and understood the contributors guide, as well as this entire template.
• I have made only one major change in my proposed changes.
• I have commented my proposed changes within the code.
• I have tested my proposed changes, and have included unit tests where possible.
• I am willing to help maintain this change if there are issues with it later.
• I give this submission freely and claim no ownership.
• It is compatible with the EUPL 1.2 license
• I have squashed any insignificant commits. (git rebase)

---

What does this PR aim to accomplish?:

See title

How does this PR accomplish the above?:

Test 1

Adding doubleclick.net on the blacklist shows:

Trying to add it again shows:

Test 2

Remove doubleclick.net from the blacklist and add doubleclick.net doubleclick.net`:

Again trying to add doubleclick.net doubleclick.net shows:

What documentation changes (if any) are needed to support this PR?:

None

[yubiuser]

Warning #2 and #4 should not state "Success" and be not green.

[DL6ER]

@yubiuser So what instead? Orange warnings?

After all, what the user asked for happened: All domains are on the list. In my opinion, it's not important if they were there before, the user wants them to be on the list and they are.

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/slight-bug-in-blacklist-uniqueness-constraint/33791/20

[yubiuser]

Mhh.. good point. I thought of "Warning" and orange.

But you're right the users want to see it on the list and you just telling them they are already. No further actions of the users is required - so no "real" warning.

P.S. Maybe I was distracted by the title of the PR stating "warning". In the end it is improved success message ;-)

[DL6ER]

Thanks, I edited the title to make it more clear.

[PromoFaux]

Ignore my fat fingers forgetting how to type... If the list type has changed, is it possible to make the message say "[domain] has been moved from [type]list to [type]list", or is that too big an ask?

[DL6ER]

How would you like to see this happening technically?

[PromoFaux]

I'm not 100% sure. It was just something that stuck out when I was testing

[DL6ER]

@PromoFaux I checked how we could do this but the REPLACE action will silently replace the entry without us noticing. When we're in FTL, we can actually catch this using an update hook, however, I checked the PHP::SQLite3 docs and see that no such thing is available here.

So idea: Count number of domains for the same type? If this changed but the total number didn't, then the action was moving the domain from another type to here.

[DL6ER]

@PromoFaux Well, wait, we support adding two independent copies to the white- and blacklist so conversion does actually never happen?

[PromoFaux]

You're right, I was testing against an older version of the db schema

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1