remove outdated local help page, link to docs instead #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Warner <[email protected]>
DL6ER
approved these changes
May 29, 2020
XhmikosR
reviewed
May 30, 2020
| <!-- Docs --> | ||
| <li> | ||
| <a href="https://docs.pi-hole.net/" rel="noopener" target="_blank"> | ||
| <i class="fa-question-circle"></i> <span>Donate</span> |
There was a problem hiding this comment.
This should have been fa fa-question-circle and not say Donate :P
|
If this is not an interim solution I'd like to suggest two things:
|
|
help.php is removed already. |
|
I would also argue about the page removal. It wasn't that bad... |
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/onboard-help-in-v5-is-in-status-v4-5/33598/5 |
Merged
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase)What does this PR aim to accomplish?:
Title