Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean table classes #1367

Merged
merged 4 commits into from
May 25, 2020
Merged

Clean table classes #1367

merged 4 commits into from
May 25, 2020

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented May 24, 2020

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

There should be no user visible changes.

Refs #1354

XhmikosR added 3 commits May 24, 2020 16:05
These are DataTables classes which we don't use since we use Bootstrap.

Signed-off-by: XhmikosR <[email protected]>
Also, add the missing `table` class in a network table.

Signed-off-by: XhmikosR <[email protected]>
@XhmikosR XhmikosR marked this pull request as ready for review May 24, 2020 13:30
@XhmikosR XhmikosR marked this pull request as draft May 24, 2020 13:53
This reverts commit 59ea121.

Apparently, we are doing something weird in the settings tables and this doesn't work. We should revisit this later.

Signed-off-by: XhmikosR <[email protected]>
@XhmikosR XhmikosR marked this pull request as ready for review May 24, 2020 14:16
@XhmikosR XhmikosR mentioned this pull request May 25, 2020
@DL6ER DL6ER merged commit 621e65b into devel May 25, 2020
@DL6ER DL6ER deleted the clean-table-classes branch May 25, 2020 18:33
@XhmikosR XhmikosR added this to the v5.1 milestone May 29, 2020
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants