-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HOSTNAME diagnostics message #1356
Conversation
c1ef491
to
2648c73
Compare
7f02aab
to
89735fd
Compare
IE compatibility should be restored + the branch is rebased onto latest |
I don't see why this can't work? for (var i = 0; i < row.blob2 + row.message.length + 2; i++) {
hint += " ";
} |
Just chucking this in the ring: var hint = new Array(row.blob2 + row.message.length + 3).join(" "); |
@XhmikosR This works as well, however, it is really verbose for a very simple task. It adheres to our style criteria and is ready to merge IMO. @PromoFaux We can use this as well, can you commit/ppush it? It is also worth pointing out that the failed node tests do not have to do with the changes in this PR. |
I honestly don't see how it's more verbose... I mean, the whole codebase is verbose :P Anyway, prettier will go away soon. |
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
d9dce13
to
8728f67
Compare
8728f67
to
bc5e9ff
Compare
Signed-off-by: Adam Warner <[email protected]>
bc5e9ff
to
075c474
Compare
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1 |
By submitting this pull request, I confirm the following:
git rebase
)What does this PR aim to accomplish?:
Add host name error messages/warnings to the Pi-hole diagnostics system
How does this PR accomplish the above?:
Add front end support for pi-hole/FTL#780
What documentation changes (if any) are needed to support this PR?:
None