Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HOSTNAME diagnostics message #1356

Merged
merged 3 commits into from
Jun 4, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented May 23, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Add host name error messages/warnings to the Pi-hole diagnostics system

Screenshot from 2020-05-23 11-20-53

How does this PR accomplish the above?:

Add front end support for pi-hole/FTL#780

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER DL6ER added this to the v5.1 milestone May 23, 2020
@DL6ER DL6ER requested a review from a team May 23, 2020 09:24
@DL6ER DL6ER force-pushed the tweak/hostname_error_message branch from c1ef491 to 2648c73 Compare May 23, 2020 09:28
@DL6ER DL6ER force-pushed the tweak/hostname_error_message branch from 7f02aab to 89735fd Compare May 25, 2020 18:11
@DL6ER
Copy link
Member Author

DL6ER commented May 25, 2020

IE compatibility should be restored + the branch is rebased onto latest devel.

@XhmikosR
Copy link
Contributor

I don't see why this can't work?

for (var i = 0; i < row.blob2 + row.message.length + 2; i++) {
  hint += " ";
}

@PromoFaux
Copy link
Member

Just chucking this in the ring:

var hint = new Array(row.blob2 + row.message.length + 3).join(" ");

@DL6ER
Copy link
Member Author

DL6ER commented Jun 2, 2020

@XhmikosR This works as well, however, it is really verbose for a very simple task. It adheres to our style criteria and is ready to merge IMO. @PromoFaux We can use this as well, can you commit/ppush it?

It is also worth pointing out that the failed node tests do not have to do with the changes in this PR.

@XhmikosR
Copy link
Contributor

XhmikosR commented Jun 2, 2020

I honestly don't see how it's more verbose... I mean, the whole codebase is verbose :P

Anyway, prettier will go away soon.

scripts/pi-hole/js/messages.js Outdated Show resolved Hide resolved
@PromoFaux PromoFaux force-pushed the tweak/hostname_error_message branch from d9dce13 to 8728f67 Compare June 3, 2020 17:07
@PromoFaux PromoFaux force-pushed the tweak/hostname_error_message branch from 8728f67 to bc5e9ff Compare June 3, 2020 17:12
@PromoFaux PromoFaux force-pushed the tweak/hostname_error_message branch from bc5e9ff to 075c474 Compare June 3, 2020 19:34
@PromoFaux PromoFaux merged commit c04dd08 into devel Jun 4, 2020
@PromoFaux PromoFaux deleted the tweak/hostname_error_message branch June 4, 2020 17:16
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants