Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default sort on DHCP lease tables to that of Hostname for ease of Access #1327

Merged
merged 1 commit into from
May 18, 2020

Conversation

PromoFaux
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

See FR on Discourse

Thought about it, and it makes sense. One is more likely to sort by hostname or IP immediately upon loading the page. I don't think I know anybody that knows all of the devices on their network by MAC address 😏

@PromoFaux PromoFaux requested review from XhmikosR and DL6ER May 18, 2020 17:24
Copy link
Contributor

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it makes more sense to default to this

@PromoFaux PromoFaux merged commit 80d7d89 into devel May 18, 2020
@PromoFaux PromoFaux deleted the tweak/dhcpTableOrdering branch May 18, 2020 18:30
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants