Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sidebar #1303

Merged
merged 2 commits into from
May 17, 2020
Merged

Improve sidebar #1303

merged 2 commits into from
May 17, 2020

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented May 16, 2020

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

This is untested, I'll try to test it soon

@XhmikosR
Copy link
Contributor Author

I kept the last patch as a separate one because you guys might prefer the previous icon and without the transition. The branch as is should be what the latest AdminLTE 2.x demo uses https://adminlte.io/themes/AdminLTE/index2.html

@XhmikosR XhmikosR marked this pull request as ready for review May 16, 2020 17:04
@XhmikosR XhmikosR requested review from DL6ER and PromoFaux May 16, 2020 17:04
@PromoFaux PromoFaux merged commit 11ee463 into devel May 17, 2020
@PromoFaux PromoFaux deleted the xmr-sidebar branch May 17, 2020 10:10
@XhmikosR XhmikosR added this to the v5.1 milestone May 29, 2020
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants