Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable no-zero-fractions rule #1298

Merged
merged 1 commit into from
May 25, 2020
Merged

Enable no-zero-fractions rule #1298

merged 1 commit into from
May 25, 2020

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented May 16, 2020

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

Should fail and help us identify places where we should use toFixed().

Refs https://github.com/pi-hole/pi-hole/issues/3362

/CC @DL6ER feel free to push to this branch and related patches and see if it fixes https://github.com/pi-hole/pi-hole/issues/3362 🙂

@XhmikosR XhmikosR force-pushed the XhmikosR-patch-5 branch from 667c4f5 to 6230873 Compare May 17, 2020 12:04
@XhmikosR XhmikosR marked this pull request as ready for review May 22, 2020 08:47
@DL6ER DL6ER merged commit 61a3ec1 into devel May 25, 2020
@DL6ER DL6ER deleted the XhmikosR-patch-5 branch May 25, 2020 17:48
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants