Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lessen chance of elements being blocked by browser blockers #1296

Merged
merged 1 commit into from
May 15, 2020

Conversation

PromoFaux
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Per #1295 and this thread on discourse

Whilst technically "not our problem" it's simple enough to do and saves the occasional confusion when these two elements have no information in them.

Of course, we could also just change the names of the API properties, BUT that is more destructive to those that are using the API externally.

@PromoFaux PromoFaux requested review from XhmikosR and DL6ER May 15, 2020 08:28
@PromoFaux PromoFaux changed the title Lessen chance of elements being blocked by 1Blocker Lessen chance of elements being blocked by browser blockers May 15, 2020
@dschaper
Copy link
Member

LGTM, not sure if there are other places that need the changes made, guess we'll find out!

@PromoFaux PromoFaux merged commit 910fac1 into devel May 15, 2020
@PromoFaux PromoFaux deleted the tweak/el_names branch May 15, 2020 15:21
@XhmikosR XhmikosR added this to the v5.1 milestone May 29, 2020
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants