Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
Make life easier for people who copy & paste values into fields.
Trims user input fields:
groups-clients.php
view#ip-custom
field (groups-client.js:254
), it's trimmed ingroups.php:242
so it doesn't make sense to not trim it heresettings.php?tab=dns
viewconditionalForwardingIP
andconditionalForwardingDomain
settings.php?tab=piholedhcp
viewfrom
,to
,router
,domain
,leasetime
AddMAC
,AddIP
,AddHostname
dns_records.php
viewip
anddomain
Some of those changes were in #825 but the PR was closed.
How does this PR accomplish the above?:
Added
trim()
calls in appropriate placesWhat documentation changes (if any) are needed to support this PR?:
None
I think I got all of them ? Other fields (whitelist/blacklist) are trimmed already.