Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocomplete bug on group pages #1287

Merged
merged 1 commit into from
May 13, 2020
Merged

Fix autocomplete bug on group pages #1287

merged 1 commit into from
May 13, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented May 13, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Fix a Javascript error on the group pages

How does this PR accomplish the above?:

Do not try to change an element before it is created

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER DL6ER added the Bugfix label May 13, 2020
@DL6ER DL6ER added this to the v5.1 milestone May 13, 2020
@DL6ER DL6ER requested a review from PromoFaux May 13, 2020 21:55
@DL6ER DL6ER merged commit 56990c5 into devel May 13, 2020
@DL6ER DL6ER deleted the fix/autocomplete_bug branch May 13, 2020 22:00
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants