Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the minified animate.css file. #1263

Merged
merged 1 commit into from
May 17, 2020
Merged

Use the minified animate.css file. #1263

merged 1 commit into from
May 17, 2020

Conversation

XhmikosR
Copy link
Contributor

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

By default, bootstrap-notify only needs a few classes, but at least this is less bloated.

I could only keep the needed default animations in another PR if you guys prefer that. The difference will be huge, but it will mean we'll need to customize a vendor file.

I only tested this on the browser, so it needs another test just to be 100% safe.

@XhmikosR XhmikosR requested a review from PromoFaux May 11, 2020 14:54
@DL6ER
Copy link
Member

DL6ER commented May 11, 2020

I only tested this on the browser, so it needs another test just to be 100% safe.

Which kind of tests?

@XhmikosR
Copy link
Contributor Author

Just if everything looks good, although it should be moot indeed. Just merge this :)

@PromoFaux
Copy link
Member

but it will mean we'll need to customize a vendor file.

I'd rather not to that if we can help it.

@XhmikosR
Copy link
Contributor Author

Yeah, that's why I went with the minified file for now to keep things simple :)

@PromoFaux PromoFaux merged commit f4722cf into devel May 17, 2020
@PromoFaux PromoFaux deleted the xmr-animate-min branch May 17, 2020 12:05
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants