Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pi-hole.net donate page instead of direct link to Paypal #1248

Merged
merged 1 commit into from
May 9, 2020

Conversation

PromoFaux
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Rationale behind this: If we, for whatever reason, decide to switch away from Paypal, then we no longer have to push an update to the web interface, we can just update directly on pi-hole.net

Also, as per referenced issue below, the donate page on pi-hole.net is a bit more multi-currency friendly than the direct paypal link

Closes #1246

@PromoFaux PromoFaux requested review from dschaper and DL6ER May 9, 2020 12:04
@DL6ER DL6ER merged commit b6d3d6c into release/v5.0 May 9, 2020
@DL6ER DL6ER deleted the tweak/donatelink branch May 9, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants