Remove unneeded xo suppression.

[XhmikosR]

Signed-off-by: XhmikosR [email protected]

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

• I have read and understood the contributors guide, as well as this entire template.
• I have made only one major change in my proposed changes.
• I have commented my proposed changes within the code.
• I have tested my proposed changes.
• I am willing to help maintain this change if there are issues with it later.
• I give this submission freely and claim no ownership.
• It is compatible with the EUPL 1.2 license
• I have squashed any insignificant commits. (git rebase)
• I have Signed Off all commits. (git commit --signoff)

---

What does this PR aim to accomplish?:

{A detailed description, screenshots (if necessary), as well as links to any relevant GitHub issues}

How does this PR accomplish the above?:

{A detailed description (such as a changelog) and screenshots (if necessary) of the implemented fix}

What documentation changes (if any) are needed to support this PR?:

{A detailed list of any necessary changes}

• {Please delete this quoted section when opening your pull request}
• You must follow the template instructions. Failure to do so will result in your issue being closed.
• Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.
• Detail helps us understand an issue quicker, but please ensure it's relevant.

[DL6ER]

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/string-content.md

Why do you want to remove this? Is it off by default?
I'm also thinking about future code contributions and if this rule can still be useful to reject bad things.

[XhmikosR]

Because the rule does nothing right now.. We can add it back if needed later.

[dschaper]

There's no patterns declared in the existing, correct? So it really wasn't doing anything?

[XhmikosR]

Yeah.

[XhmikosR]

BTW this targeted the devel branch, not sure if that's right. If not please cherry pick it and delete the develop branch. I didn't quite follow the changes the changes :)