Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow too long legend lines to break #1230

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Apr 28, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Fixes #1220

How does this PR accomplish the above?:

Allow too long legend lines to break

BEFORE
Screenshot at 2020-04-27 23-22-17

AFTER
Screenshot at 2020-04-27 23-24-24

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER DL6ER added the Bugfix label Apr 28, 2020
@DL6ER DL6ER added this to the v5.0 milestone Apr 28, 2020
@DL6ER DL6ER requested a review from a team April 28, 2020 18:43
@DL6ER DL6ER linked an issue Apr 28, 2020 that may be closed by this pull request
@dschaper
Copy link
Member

It looks kind of ugly to me, but I see that it's necessary. Begrudging approval from me ;)

@dschaper dschaper merged commit 34d9942 into release/v5.0 Apr 28, 2020
@dschaper dschaper deleted the fix/long_doghnout_legends branch April 28, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line breaks on dashboard gauge's legend
2 participants