Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ( and ) in adlist URLs. #1226

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Apr 26, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Fix pi-hole/pi-hole#3284

How does this PR accomplish the above?:

Allow ( and ) in adlist URLs

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER DL6ER added this to the v5.0 milestone Apr 26, 2020
@DL6ER DL6ER requested a review from a team April 26, 2020 07:35
@dschaper dschaper merged commit eaf2d7e into release/v5.0 Apr 28, 2020
@dschaper dschaper deleted the tweak/allow_()_in_urls branch April 28, 2020 18:46
@p1r473
Copy link

p1r473 commented May 6, 2020

Tested, works great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants