Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit about window.location #1088

Merged
merged 1 commit into from
Dec 28, 2019
Merged

Be explicit about window.location #1088

merged 1 commit into from
Dec 28, 2019

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Dec 17, 2019

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

This doesn't change anything but it makes it clear that we access location from the window object, which is already done in all other cases.

@DL6ER
Copy link
Member

DL6ER commented Dec 17, 2019

https://www.w3schools.com/jsref/obj_location.asp doesn't seem to mention anything about window.

@XhmikosR
Copy link
Contributor Author

You need to choose better references :)

The global object in browsers is the window object. https://developer.mozilla.org/en-US/docs/Web/API/Window/location

@XhmikosR
Copy link
Contributor Author

Just for historical reasons https://web.archive.org/web/20110412103745/http://w3fools.com/

@DL6ER DL6ER merged commit 03b3a1d into devel Dec 28, 2019
@DL6ER DL6ER deleted the location branch December 28, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants