Code

Add group management#1076

Code

Merged

DL6ER merged 46 commits intodevelpi-hole/web:develfrom new/group-managementpi-hole/web:new/group-managementCopy head branch name to clipboardDec 28, 2019

+8,128-178

Commits

Commits on Dec 13, 2019

• Update DataTables from 1.10.12 to 1.10.20

  Show description for 99462ec
  DL6ER

  committed
  99462ec

  Copy full SHA for 99462ec

• Add group management page

  Show description for 3e23aa6
  DL6ER

  committed
  3e23aa6

  Copy full SHA for 3e23aa6

• Add Client group management

  Show description for 600c16c
  DL6ER

  committed
  600c16c

  Copy full SHA for 600c16c

• Add Domain Group Management

  Show description for 912e2dd
  DL6ER

  committed
  912e2dd

  Copy full SHA for 912e2dd

• Add Adlists group management

  Show description for 70589fa
  DL6ER

  committed
  70589fa

  Copy full SHA for 70589fa

• Make sure all fields are searchable on all pages (where this is meaningful) and remove ID column from clients group page.

  Show description for b025ffd
  DL6ER

  committed
  b025ffd

  Copy full SHA for b025ffd

• Add missing form-control classes for proper element styling.

  Show description for 50f05b9
  DL6ER

  committed
  50f05b9

  Copy full SHA for 50f05b9

• Use toggle for Enabled/Disabled switch

  Show description for b62c550
  DL6ER

  committed
  b62c550

  Copy full SHA for b62c550

• Address stickler complaints.

  Show description for cf96bed
  DL6ER

  committed
  cf96bed

  Copy full SHA for cf96bed

• Add tooltips for creation and modification times for domains and adlists.

  Show description for a83c9c9
  DL6ER

  committed
  a83c9c9

  Copy full SHA for a83c9c9

• Correctly interpret toogle value.

  Show description for 9950ca5
  DL6ER

  committed
  9950ca5

  Copy full SHA for 9950ca5

• Remove assignment from if-statement to please CodeFactor.

  Show description for 3b7e507
  DL6ER

  committed
  3b7e507

  Copy full SHA for 3b7e507

• Add CORS and CSRF checks to ensure unauthorized access to the backend is not possible.

  Show description for aa764ad
  DL6ER

  committed
  aa764ad

  Copy full SHA for aa764ad

• Ensure large table is only loaded when groups are known.

  Show description for aa6c4c8
  DL6ER

  committed
  aa6c4c8

  Copy full SHA for aa6c4c8

Commits on Dec 14, 2019

• Use single quotes almost everywhere, use !== where appropriate, fix formatting and simplify the code in some places.

  Show description for b791c29
  DL6ER

  committed
  b791c29

  Copy full SHA for b791c29

• Apply PSR-12 style to all new PHP files added in this pull request.

  Show description for acf19c0
  DL6ER

  committed
  acf19c0

  Copy full SHA for acf19c0

• Use prettier to reformat JS files added in this PR.

  Show description for a75117a
  DL6ER

  committed
  a75117a

  Copy full SHA for a75117a

• Use JS dot-notation as it is less verbose

  Show description for 6bc72d2
  DL6ER

  committed
  6bc72d2

  Copy full SHA for 6bc72d2

Commits on Dec 16, 2019

• Send token when adding new group. Otherwise, we get a "Not allowed" response.

  Show description for 6f3495d
  DL6ER

  committed
  6f3495d

  Copy full SHA for 6f3495d

• Show raw response (like "Not allowed") when encountering an error. This is actually not all that unlikely as a user might have the page open for longer time and wants to add(edit/delete a group/cli…

  Show description for 509574b
  DL6ER

  committed
  509574b

  Copy full SHA for 509574b

• Run prettier on most recent changes.

  Show description for 7c9d77d
  DL6ER

  committed
  7c9d77d

  Copy full SHA for 7c9d77d

• Say explicitly why a "Not allowed" error comes from.

  Show description for 49be667
  DL6ER

  committed
  49be667

  Copy full SHA for 49be667

• Merge branch 'devel' into new/group-management

  DL6ER

  committed
  95c893d

  Copy full SHA for 95c893d

Commits on Dec 17, 2019

• Also delete assignments form domains, adlists and clients to a group when it is deleted.

  Show description for 18682eb
  DL6ER

  committed
  18682eb

  Copy full SHA for 18682eb

• Also show database ID in tooltip.

  Show description for 232cfdb
  DL6ER

  committed
  232cfdb

  Copy full SHA for 232cfdb

• Use bootstrap notify for notifications.

  Show description for d0d1174
  DL6ER

  committed
  d0d1174

  Copy full SHA for d0d1174

• Prevent users from adding empty groups/domains/clients/adlists.

  Show description for da2d92e
  DL6ER

  committed
  da2d92e

  Copy full SHA for da2d92e

• Use titles in notifications.

  Show description for 51edb07
  DL6ER

  committed
  51edb07

  Copy full SHA for 51edb07

• Merge branch 'devel' into new/group-management

  DL6ER

  committed
  ae08443

  Copy full SHA for ae08443

Commits on Dec 19, 2019

• Show host names (if known) on the Clients management page.

  Show description for 0500218
  DL6ER

  committed
  0500218

  Copy full SHA for 0500218

• Replace pencil button by automatic saving (so far, only for the groups.php page)

  Show description for a2031c0
  DL6ER

  committed
  a2031c0

  Copy full SHA for a2031c0

• Sort by first column by default (zero-indexed)

  Show description for 5aa6b1d
  DL6ER

  committed
  5aa6b1d

  Copy full SHA for 5aa6b1d

Commits on Dec 20, 2019

• Remove ID column from group management page.

  Show description for 5e2561a
  DL6ER

  committed
  5e2561a

  Copy full SHA for 5e2561a

• Remove ID displaying for groups from all pages.

  Show description for 4aa3551
  DL6ER

  committed
  4aa3551

  Copy full SHA for 4aa3551

• Include but hide ID column on the group management page. Add "Reset sorting" button enabling the user to go back to ID sorting (initial behavior, makes sure group 0 is at the top).

  Show description for 1c3d635
  DL6ER

  committed
  1c3d635

  Copy full SHA for 1c3d635

• Add tooltip to group name input fields.

  Show description for 26c9a55
  DL6ER

  committed
  26c9a55

  Copy full SHA for 26c9a55

• Add auto-saving to all group management pages.

  Show description for 4f54796
  DL6ER

  committed
  4f54796

  Copy full SHA for 4f54796

• Add "Reset Sorting" button to remaining pages.

  Show description for ede9d41
  DL6ER

  committed
  ede9d41

  Copy full SHA for ede9d41

• Fix navigation submenu.

  Show description for 7dc5c5c
  DL6ER

  committed
  7dc5c5c

  Copy full SHA for 7dc5c5c

• Reset visibility of ID column on table loading

  Show description for 772d52c
  DL6ER

  committed
  772d52c

  Copy full SHA for 772d52c

• Update nav icons.

  Show description for ee91b3b
  DL6ER

  committed
  ee91b3b

  Copy full SHA for ee91b3b

Commits on Dec 23, 2019

• Convert domains to lower-case and validate them before adding them.

  Show description for 563aaa1
  DL6ER

  committed
  563aaa1

  Copy full SHA for 563aaa1

• We have to get the group's ID from the hidden field now that we removed/hide the IP column by default.

  Show description for cce7c92
  DL6ER

  committed
  cce7c92

  Copy full SHA for cce7c92

• Improve error messages.

  Show description for a80355c
  DL6ER

  committed
  a80355c

  Copy full SHA for a80355c

• Do not reload table on successfull edits and deletions.

  Show description for b840d21
  DL6ER

  committed
  b840d21

  Copy full SHA for b840d21

Commits on Dec 28, 2019

• Do not go back to page 1 when deleting an item.

  Show description for 9b7daa3
  DL6ER

  committed
  9b7daa3

  Copy full SHA for 9b7daa3