Query Log > Recent Queries > "Apply filtering on click on Type, Domain, and Clients" not Not reflected in UI hover text

[sciatro]

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

• I have read and understood the contributors guide.
• The issue I am reporting can be replicated.
• The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

How familiar are you with the the source code relevant to this issue?:

0

---

Expected behaviour:

"Query Log" hover / alt text should be accurate regardless of "Apply filtering on click on Type, Domain, and Clients" setting.

Actual behaviour:

When "Apply filtering on click on Type, Domain, and Clients" is unchecked the hover text on any of the filterable elements within the Query Log table (e.g. "Click to show only A queries") continues to appear even though unchecking "Apply ..." renders it incorrect.

Steps to reproduce:

1. Login to the admin and go to Query Log (http://pi.hole/admin/queries.php)
2. Hover your pointer over any of the hrefs in the Recent Queries table and note descriptive and correct alt text (~ clicking this will filter to only this)
3. Unchecked "Apply filtering on click on Type, Domain, and Clients" at the bottom
4. Repeat step 2, but now note that the hover / alt text is now incorrect.

Unlikely anyone sophisticated enough to run a pi-hole is going to be befuddled by this bug but it's clearly a bug (and a good reminder of how hard it was / is to manage state in the DOM by hand).