Apply suggestions from code review

pi-hole · Dec 29, 2021 · 9d0de39 · 9d0de39
1 parent d10ad1d
commit 9d0de39
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/scripts/pi-hole/php/header.php b/scripts/pi-hole/php/header.php
@@ -337,13 +337,13 @@ function pidofFTL()
                         } else {
                             $pistatus = null;
                         }
-                        if ($pistatus == "53") {
+                        if ($pistatus == 53) {
                             echo '<span id="status"><i class="fa fa-circle text-green-light"></i> Active</span>';
-                        } elseif ($pistatus == "0") {
+                        } elseif ($pistatus == 0) {
                             echo '<span id="status"><i class="fa fa-circle text-red"></i> Offline</span>';
-                        } elseif ($pistatus == "-1") {
+                        } elseif ($pistatus == -1) {
                             echo '<span id="status"><i class="fa fa-circle text-red"></i> DNS service not running</span>';
-                        } elseif ($pistatus == "-2" || is_null($pistatus)) {
+                        } elseif ($pistatus == -2 || is_null($pistatus)) {
                             echo '<span id="status"><i class="fa fa-circle text-red"></i> Unknown</span>';
                         } else {
                             echo '<span id="status"><i class="fa fa-circle text-orange"></i> DNS service on port '.$pistatus.'</span>';